TASK: Granularly fix php code according to psr12 #4745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
force-pushed
the
task/runPhpstormInspections
branch
2 times, most recently
from
b1e8f13 to
80f5262
Compare
mhsdesign
changed the title
mhsdesign
force-pushed
the
task/runPhpstormInspections
branch
2 times, most recently
from
4d029b2 to
e610eae
Compare
mhsdesign
force-pushed
the
task/runPhpstormInspections
branch
from
e610eae to
7cf1df0
Compare
ahaeslich
approved these changes
Feb 14, 2024
| @@ -116,6 +116,7 @@ protected function earlyOptimizationOfFilters(FlowQuery $flowQuery, array $parse | |||
| $outputNodeAggregateIds = []; | |||
| foreach ($parsedFilter['Filters'] as $filter) { | |||
| $instanceOfFilters = []; | |||
| // @todo array is never queried | |||
There was a problem hiding this comment.
@mhsdesign did you plan to fix this todo with a new MR?
There was a problem hiding this comment.
nö :D
But maybe martins pr might? :D #4712
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In hope of detecting invalid
@seedoc code tags i ran the phpstorm inspections. Well it didnt found those but i found a lot of other stuff.new selfinstead ofnew static(and optionally declare@Flow\Autowiring(false)to not have a proxy class)elseifoverelse { if() {} }initializeViewwas needlessly changed topublicUpgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions