BUGFIX: Partially repair convert uris implementation according to some 8.3 tests #4744
Conversation
mhsdesign
changed the title
Neos.Neos/Tests/Behavior/Features/Bootstrap/MiscellaneousTrait.php
Outdated
Show resolved
Hide resolved
imo nope its a regression to remove a feature that worked previously. |
it seems $someone tried to optimize the convert uris stuff from 8.3 while migrating the code to 9.0 Maybe we should revert those performance optimization and introduce all those additional preg_match and replaces again for more accuracy. People might already have trouble enough with 9.0 silent bugs like these will make things even harder. or we find a way to accurately performantly archive the same behaviour as in 8.3 |
OK, you're right. I just fail to give an +1 for the Are you OK with changing the trait name though – it's not a big thing, but also easy to change :) |
|
+1 for renaming the trait and then getting this in. |
|
Hmm could you please diff the 8.3 and new 9.0 convert uris implementation? im really just about to checkout the 8.3 part again and migrate it without any additional performance improvements, as those will cause bugs. this is the even more expensive but more accurate 8.3 solution. |
|
We can probably work on this at another point again, given that this is cached I don't see much problem in having this regex there, also I am sure this won't be in the top 5 of performance problems of rendering 🙈 tl;dr; fine by me to go back to this. |
…neos#3542 It currently breaks because the rel attribute is just "noopener" instead of "noopener external" This feature neos#3542 was omitted in 90
mhsdesign
force-pushed
the
bugfix/90-fix-convertUrisImplementation
branch
from
f843e39 to
0ff614f
Compare
|
Okay ill merge this now an prepare a pr where i check all neos fusion objects if they should better be remigrated ;) |
…vertUrisImplementation the convert uris stuff was optimized while migrating the code to 9.0 it should behave more performant with the cost of being less accurate and not covering all edge-cases. This change reverts those performance optimization and introduce all those additional preg_match and replaces again for more accuracy. This is the even more expensive but more accurate 8.3 solution. neos#4744 (comment)
|
see #4760 |
…vertUrisImplementation the convert uris stuff was optimized while migrating the code to 9.0 it should behave more performant with the cost of being less accurate and not covering all edge-cases. This change reverts those performance optimization and introduce all those additional preg_match and replaces again for more accuracy. This is the even more expensive but more accurate 8.3 solution. neos#4744 (comment)
…vertUrisImplementation the convert uris stuff was optimized while migrating the code to 9.0 it should behave more performant with the cost of being less accurate and not covering all edge-cases. This change reverts those performance optimization and introduce all those additional preg_match and replaces again for more accuracy. This is the even more expensive but more accurate 8.3 solution. neos#4744 (comment)
…vertUrisImplementation the convert uris stuff was optimized while migrating the code to 9.0 it should behave more performant with the cost of being less accurate and not covering all edge-cases. This change reverts those performance optimization and introduce all those additional preg_match and replaces again for more accuracy. This is the even more expensive but more accurate 8.3 solution. neos#4744 (comment)
…vertUrisImplementation the convert uris stuff was optimized while migrating the code to 9.0 it should behave more performant with the cost of being less accurate and not covering all edge-cases. This change reverts those performance optimization and introduce all those additional preg_match and replaces again for more accuracy. This is the even more expensive but more accurate 8.3 solution. neos/neos-development-collection#4744 (comment)
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions