Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: #4736 Json serialize Subgraph correctly #4739

Merged

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Nov 12, 2023

Resolves: #4736

The subgraph should also serialize its newly added cr id as well as the visibility constraints.

example output:

{"contentRepositoryId":"default","contentStreamId":"a6e86502-5867-4460-a855-4134489d6b1b","dimensionSpacePoint":{"language":"en_US"},"visibilityConstraints":"075ae3d2fc31640504f814f60e5ef713"}

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Resolves: neos#4736

example output:

```
{"contentRepositoryId":"default","contentStreamId":"a6e86502-5867-4460-a855-4134489d6b1b","dimensionSpacePoint":{"language":"en_US"},"visibilityConstraints":"075ae3d2fc31640504f814f60e5ef713"}
```
@mhsdesign mhsdesign merged commit 86582ef into neos:9.0 Feb 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContentSubgraph::jsonSerialize should serialize content stream id and visibility constraints.
2 participants