Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Inline NodeSiteResolvingService #4737

Merged
merged 1 commit into from
Nov 17, 2023
Merged

TASK: Inline NodeSiteResolvingService #4737

merged 1 commit into from
Nov 17, 2023

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Nov 12, 2023 •
edited
Loading

Since the introduction of findClosestNode and the Site node type #4563 this service became useless, and its actually less code involved and easier to read now ;)

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign
Copy link
Member Author

Ill merge this okay?

@mhsdesign mhsdesign merged commit 33a3c4b into neos:9.0 Nov 17, 2023
7 checks passed
@mhsdesign mhsdesign deleted the task/removeAndInlineInternalNodeSiteResolvingService branch November 17, 2023 12:03
@kitsunet
Copy link
Member

kitsunet commented Nov 18, 2023 •
edited
Loading

Please don't just merge stuff,

but +1 post merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsunet kitsunet kitsunet left review comments

@bwaidelich bwaidelich bwaidelich left review comments

Assignees
No one assigned
Labels
9.0 Task
Projects
Neos 9.0 Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhsdesign @kitsunet @bwaidelich