FEATURE: Site configuration presets

[bwaidelich]

Resolves: #4582

[mhsdesign]

This looks already great and seems to be non breaking. Are there any open points left?

[bwaidelich]

Are there any open points left?

I urgently need to document open tasks when I mark a PR as draft.. I don't know what I planned to do still – maybe adjust docs on docs.neos.io or add tests? 🙈

I'll mark it ready for review now

[mhsdesign]

Okay as far as i can tell is the change non breaking as the wildcard * pattern still works - though one is probably better of declaring the config for a siteNode specifically and using a preset?

~So the neos ui test dist and neos demo doesnt need to be migrated? https://github.com/neos/neos-ui/blob/5758aa4d935c9fa06dcf55a0e3b55fca3961b89e/Tests/IntegrationTests/TestDistribution/DistributionPackages/Neos.Test.OneDimension/Configuration/Settings.yaml#L35~  Exactly this change is totally non breaking.

The documentation at https://docs.neos.io/guide/manual/site-configuration would need to be updated as well please.

[mhsdesign]

This feature is needed for my masterplan in #4470 (comment)
so i will gladly approve this.

My previous concerns, to remove support for * and document on docs.neos.io will be part of my followup. Also that will keep this pr from being breaking.

[bwaidelich]

Shall we merge this?

[bwaidelich]

I rebased this one and would like to merge it if tests are green.
@mhsdesign are you OK with that?
I'll take care of the docs immediately afterwards

[mhsdesign]

Yeah sure, lets do it. (Even-though the logic really grows in the SiteConfiguration thingy and i might like to have a unit test for it 🙈)

[bwaidelich]

i might like to have a unit test for it

yes, good point! I might like to have one as well :D I'll take care

[mhsdesign]

❤️ +2 ;)

[dlubitz]

Looks good. Thank you!