BUGFIX: #3624 Node::getProperty does not always return list for references #4731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eferences EEL can only operate on an array of nodes if the `[0]` item is a node (simple duck typing) Instead of fixing eel like proposed here neos#3946 with this fix we avoid returning non 0 indexed arrays here: ``` ${q(node).property("someReference")} ``` Currently, this might indeed return an array with holes like `[1 => NODE, 2 => NODE, 5 => NODE]` if the identifiers in fields 0, 3 and 4 are not resolvable. Thats because of the "unsafe" `array_filter` method in `resolvePropertyReferences` https://github.com/neos/neos-development-collection/blob/378a029d0cc7ea6acb853751e7592873584a4aac/Neos.ContentRepository/Classes/Domain/Model/Node.php#L961 which will leave holes in the array. Using `array_filter` was introduced with Neos 2.2 so this is technically a regression of neos@87804e1 ^^
|
This one begs for a corresponding test |
bwaidelich
approved these changes
Jan 14, 2024
dlubitz
approved these changes
Jan 31, 2024
mhsdesign
deleted the
bugfix/nodeGetPropertyReturnsArrayWithHolesForReferences
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EEL can only operate on an array of nodes if the
[0]item is a node (simple duck typing)Instead of fixing eel like proposed here #3946 with this fix we avoid returning non 0 indexed arrays here:
Currently, this might indeed return an array with holes like
[1 => NODE, 2 => NODE, 5 => NODE]if the identifiers in fields 0, 3 and 4 are not resolvable.Thats because of the "unsafe"
array_filtermethod inresolvePropertyReferencesneos-development-collection/Neos.ContentRepository/Classes/Domain/Model/Node.php
Line 961 in 378a029
Using
array_filterwas introduced with Neos 2.2 so this is technically a regression of 87804e1 ^^Fixes: #3624