Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Adjust neos/neos css build to work on apple silicon #4691

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

kitsunet
Copy link
Member

@kitsunet kitsunet commented Nov 2, 2023

No description provided.

@kitsunet kitsunet requested review from markusguenther, Sebobo, jonnitto, mficzel and mhsdesign and removed request for Sebobo November 2, 2023 17:10
@kitsunet kitsunet force-pushed the task/fix-73-neos-neos-css-build branch from 0db3a84 to 175c097 Compare November 2, 2023 17:23
Copy link
Member

@jonnitto jonnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait till we ged rid of sass 🤣

Neos.Neos/package.json Outdated Show resolved Hide resolved
@kitsunet kitsunet force-pushed the task/fix-73-neos-neos-css-build branch from 175c097 to 7d2b36a Compare November 13, 2023 10:42
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care ❤️

How should we upmerge this? Rebuild and commit on every branch?

@kitsunet
Copy link
Member Author

Thanks for taking care ❤️

How should we upmerge this? Rebuild and commit on every branch?

Yeah probably necessary. I would just merge this later today and directly do the upmerges as well.

@kitsunet kitsunet merged commit 407721f into 7.3 Nov 13, 2023
7 checks passed
@kitsunet kitsunet deleted the task/fix-73-neos-neos-css-build branch November 13, 2023 19:22
@kitsunet
Copy link
Member Author

all upmerged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants