Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Set correct siteNode in WorkspaceController #4627

Merged
merged 1 commit into from
Oct 19, 2023
Merged

BUGFIX: Set correct siteNode in WorkspaceController #4627

merged 1 commit into from
Oct 19, 2023

Conversation

ahaeslich
Copy link
Member

This fixes a merge error introduced with fa38119

We check $ancestor to be of nodeType Neos.Neos:Site so this is the correct value for $siteNode.

Relates: #4588

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@ahaeslich
BUGFIX: Set correct siteNode in WorkspaceController
49efa6b 
This fixes a merge error introduced with fa38119

We check `$ancestor` to be of nodeType `Neos.Neos:Site` so this is the correct value for `$siteNode`.

Relates: #4588
@ahaeslich ahaeslich requested a review from mhsdesign October 19, 2023 08:58
@mhsdesign mhsdesign merged commit dcb033a into 9.0 Oct 19, 2023
4 checks passed
@mhsdesign mhsdesign deleted the bugfix/workspace-module-use-correct-site-node branch October 19, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsdesign mhsdesign mhsdesign approved these changes

@kitsunet kitsunet Awaiting requested review from kitsunet

@nezaniel nezaniel Awaiting requested review from nezaniel

Assignees
No one assigned
Labels
9.0 Bug
Projects
Neos 9.0 Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahaeslich @mhsdesign