4609 multiple content collection publishing

[nezaniel]

This resolves #4609

Population of NodeAggregateIdsByNodePaths is now done properly, recursively and has its own test cases

Checklist

• Code follows the PSR-12 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the 9.0 branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[mhsdesign]

i really like this method or here :D and was thinking as well to put it here.

(originally it was hidden here

neos-development-collection/Neos.ContentRepository.Core/Classes/Feature/NodeCreation/NodeCreation.php

Lines 344 to 367 in 10e6373

	protected static function populateNodeAggregateIds(
	NodeType $nodeType,
	?NodeAggregateIdsByNodePaths $nodeAggregateIds,
	NodePath $childPath = null
	): NodeAggregateIdsByNodePaths {
	if ($nodeAggregateIds === null) {
	$nodeAggregateIds = NodeAggregateIdsByNodePaths::createEmpty();
	}
	// TODO: handle Multiple levels of autocreated child nodes
	foreach ($nodeType->getAutoCreatedChildNodes() as $rawChildName => $childNodeType) {
	$childName = NodeName::fromString($rawChildName);
	$childPath = $childPath
	? $childPath->appendPathSegment($childName)
	: NodePath::fromString($childName->value);
	if (!$nodeAggregateIds->getNodeAggregateId($childPath)) {
	$nodeAggregateIds = $nodeAggregateIds->add(
	$childPath,
	NodeAggregateId::create()
	);
	}
	}
	return $nodeAggregateIds;
	}

)

Putting it here exposed will be important for the node templates package as we need it there.

Though i would prefer if there also was a static factory for this so that i dont have to write

NodeAggregateIdsByNodePaths::createEmpty()->completeForNodeOfType(...)

[nezaniel]

like this?

[mhsdesign]

yes looks pretty practical - and one can easily find this method.

$nodeAggregateIdsByNodePaths = NodeAggregateIdsByNodePaths::createForNodeType($nodeTypeName, $nodeTypeManager);

ideally we should enrich also the doc comments for the both methods about the why one would want to do this. (And maybe also a little about the "what" - that it recursively generates node ids for all declared tethered paths.)

[bwaidelich]

Bug => Test = ❤️

[mhsdesign]

I took the liberty of adjusting the documentation of CreateNodeAggregateWithNode::withTetheredDescendantNodeAggregateIds so it reflects the main user-land purpose.

Is this fine with you?