Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Remove fluid error view Neos.Neos/Private/Templates/Error/Index.html #4598

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Oct 12, 2023

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign added the 9.0 label Oct 12, 2023
@github-actions github-actions bot added the Task label Oct 12, 2023
@@ -35,8 +35,6 @@ class BackendHelper implements ProtectedContextAwareInterface
*/
public function interfaceLanguage(): string
{
$currentUser = $this->userService->getBackendUser();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fluid viewhelper neos:backend.translate could also be used in the frontend - thats why we are not so strict over here.

Copy link
Member

@nezaniel nezaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@ahaeslich ahaeslich changed the title TASK: Remove fluid error view `Neos.Neos/Private/Templates/Error/Inde… TASK: Remove fluid error view Neos.Neos/Private/Templates/Error/Index.html Oct 16, 2023
@ahaeslich ahaeslich merged commit 6b11cc7 into 9.0 Oct 16, 2023
@ahaeslich ahaeslich deleted the task/removeFluidRenderingForFusionErrorExceptionView branch October 16, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants