Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Removes EventLog and history module #4592

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

markusguenther
Copy link
Member

@markusguenther markusguenther commented Oct 11, 2023

Remove the legacy history module and event log due to incompatibility with NeosCMS 9.0's Event Sourced Content Repository. Future enhancements will be based on event-driven features.

Upgrade instructions

You can remove the setting for the eventLog in your project, but it does not harm if you keep it.

Review instructions

Check if the eventLog stuff and the history module is gone and nothing is broken.

Resolves: #4553

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@markusguenther markusguenther changed the title TASK: Removes EventLog and History module TASK: Removes EventLog and history module Oct 11, 2023
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading, thanks for taking care!

@markusguenther
Copy link
Member Author

Unit tests failed... but need to check if it comes from my change 🙈

@markusguenther
Copy link
Member Author

It seems that the failing test from the RedisBackend is not from my changes. I also have it for 9.0 branch locally.

@ahaeslich
Copy link
Member

It seems that the failing test from the RedisBackend is not from my changes. I also have it for 9.0 branch locally.

They also suddenly failed here: neos/flow-development-collection#3172 (comment)

Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great so far ;)

i think we should remove the old doctrine migrations so we dont have the neos_neos_eventlog_domain_model_event table anymore no?

related #4240

@markusguenther
Copy link
Member Author

@mhsdesign Table has been removed!

@mhsdesign
Copy link
Member

Thanks. Im still not sure if it wouldnt be better to clean up those old 10 migrations but i created a follow up:
#4594

Remove legacy history module and event log due to incompatibility with NeosCMS 9.0's Event Sourced Content Repository. Future enhancements will be based on event-driven features.
@markusguenther markusguenther force-pushed the task/remove-eventlog-and-history-module branch from f363b72 to 7fb1382 Compare October 13, 2023 06:47
@ahaeslich ahaeslich merged commit e7b9543 into 9.0 Oct 13, 2023
5 checks passed
@ahaeslich ahaeslich deleted the task/remove-eventlog-and-history-module branch October 13, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9.0 State of History Module
4 participants