-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Removes EventLog and history module #4592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 by reading, thanks for taking care!
Unit tests failed... but need to check if it comes from my change 🙈 |
It seems that the failing test from the RedisBackend is not from my changes. I also have it for 9.0 branch locally. |
They also suddenly failed here: neos/flow-development-collection#3172 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great so far ;)
i think we should remove the old doctrine migrations so we dont have the neos_neos_eventlog_domain_model_event
table anymore no?
related #4240
@mhsdesign Table has been removed! |
Thanks. Im still not sure if it wouldnt be better to clean up those old 10 migrations but i created a follow up: |
Remove legacy history module and event log due to incompatibility with NeosCMS 9.0's Event Sourced Content Repository. Future enhancements will be based on event-driven features.
f363b72
to
7fb1382
Compare
Remove the legacy history module and event log due to incompatibility with NeosCMS 9.0's Event Sourced Content Repository. Future enhancements will be based on event-driven features.
Upgrade instructions
You can remove the setting for the
eventLog
in your project, but it does not harm if you keep it.Review instructions
Check if the
eventLog
stuff and the history module is gone and nothing is broken.Resolves: #4553
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions