-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Add current node to site changes computation #4573
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahaeslich
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also fixes that in 9.0 the path above the changes would not containe the current node anymore.
bwaidelich
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By reading
ahaeslich
added a commit
that referenced
this pull request
Oct 8, 2023
- Fix assignment of `siteNode` - Fix path generation to fix grouping of changes by document - Fix publishing of deleted node - Fix checkbox behaviour to not publish new child nodes independent of parent Relates: #4573
1 task
ahaeslich
added a commit
to queoGmbH/neos-development-collection
that referenced
this pull request
Oct 8, 2023
- Fix assignment of `siteNode` - Fix path generation to fix grouping of changes by document - Fix publishing of deleted node - Fix checkbox behaviour to not publish new child nodes independent of parent Relates: neos#4573
ahaeslich
added a commit
that referenced
this pull request
Oct 12, 2023
ahaeslich
added a commit
that referenced
this pull request
Oct 12, 2023
ahaeslich
added a commit
to queoGmbH/neos-development-collection
that referenced
this pull request
Oct 14, 2023
- Fix assignment of `siteNode` - Fix path generation to fix grouping of changes by document - Fix publishing of deleted node - Fix checkbox behaviour to not publish new child nodes independent of parent Relates: neos#4573
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4572
Adds the current node to the site changes computation. This allows to find changes to document nodes themself, including the site document node.