Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Add current node to site changes computation #4573

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Oct 3, 2023

Fixes: #4572

Adds the current node to the site changes computation. This allows to find changes to document nodes themself, including the site document node.

@dlubitz dlubitz self-assigned this Oct 3, 2023
@github-actions github-actions bot added the Bug label Oct 3, 2023
Copy link
Member

@ahaeslich ahaeslich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also fixes that in 9.0 the path above the changes would not containe the current node anymore.

Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By reading

@dlubitz dlubitz merged commit 08c3b5a into 9.0 Oct 4, 2023
5 checks passed
@dlubitz dlubitz deleted the 90/bugfix/workspace-changes branch October 4, 2023 10:42
ahaeslich added a commit that referenced this pull request Oct 8, 2023
- Fix assignment of `siteNode`
- Fix path generation to fix grouping of changes by document
- Fix publishing of deleted node
- Fix checkbox behaviour to not publish new child nodes independent of parent

Relates: #4573
ahaeslich added a commit to queoGmbH/neos-development-collection that referenced this pull request Oct 8, 2023
- Fix assignment of `siteNode`
- Fix path generation to fix grouping of changes by document
- Fix publishing of deleted node
- Fix checkbox behaviour to not publish new child nodes independent of parent

Relates: neos#4573
ahaeslich added a commit that referenced this pull request Oct 12, 2023
ahaeslich added a commit that referenced this pull request Oct 12, 2023
ahaeslich added a commit to queoGmbH/neos-development-collection that referenced this pull request Oct 14, 2023
- Fix assignment of `siteNode`
- Fix path generation to fix grouping of changes by document
- Fix publishing of deleted node
- Fix checkbox behaviour to not publish new child nodes independent of parent

Relates: neos#4573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

BUG: Changes to "Site" node (Homepage) are not shown in workspace module
3 participants