BUGFIX: FusionExceptionView must use mocked controller context #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f24c72 (#4425) introduced a regression where we accidentally used `$this->controllerContext` instead of `$controllerContext`. For $some reason we have to use the mocked controller context, as otherwise the `${request.format}` will be empty "" in fusion. And this causes trouble in the `/root` matcher. This fix uses the mocked controller context again.
mhsdesign
deleted the
bugfix/fusionExceptionViewUsesWrongRequestWithoutControllerContext
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0f24c72 (#4425) introduced a regression where we accidentally used
$this->controllerContextinstead of$controllerContext.For $some reason we have to use the mocked controller context, as otherwise the
${request.format}will be empty "" in fusion. And this causes trouble in the/rootmatcher.This fix uses the mocked controller context again.
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions