Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!!! TASK: Remove NodeType::getName() and replace usages #4562

Merged
merged 1 commit into from
Sep 28, 2023
Merged

!!! TASK: Remove NodeType::getName() and replace usages #4562

merged 1 commit into from
Sep 28, 2023

Conversation

mhsdesign
Copy link
Member

Resolves: #4560

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign mentioned this pull request Sep 26, 2023
Merged
kitsunet
kitsunet approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a rector rule for node.nodeType.name because that would have to be adapted then? otherwise it could very much make sense to have one.

bwaidelich
bwaidelich approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment •
edited by mhsdesign
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading, and +1 for a rector migration :)

@mhsdesign mhsdesign linked an issue Sep 28, 2023 that may be closed by this pull request
!!! Remove NodeType::getName #4560
Closed
@mhsdesign mhsdesign merged commit f02344c into nodeTypeFallbackHandling Sep 28, 2023
1 check passed
@mhsdesign mhsdesign deleted the task/removeNodeTypeGetName branch September 28, 2023 12:48
@mhsdesign mhsdesign mentioned this pull request Jul 3, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsunet kitsunet kitsunet approved these changes

@bwaidelich bwaidelich bwaidelich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

!!! Remove NodeType::getName
3 participants
@mhsdesign @bwaidelich @kitsunet