Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: NodeType::isOfType allow NodeTypeName as $nodeTypeName #4556

Merged
merged 1 commit into from
Sep 29, 2023
Merged

TASK: NodeType::isOfType allow NodeTypeName as $nodeTypeName #4556

merged 1 commit into from
Sep 29, 2023

Conversation

mhsdesign
Copy link
Member

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign added the 9.0 label Sep 23, 2023
@github-actions github-actions bot added the Task label Sep 23, 2023
@mhsdesign mhsdesign added 9.0beta1 and removed Task labels Sep 23, 2023
dlubitz
dlubitz approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@dlubitz dlubitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But why not make the parameter NodeTypeName only?

@mhsdesign mhsdesign mentioned this pull request Sep 16, 2023
Closed
@mhsdesign mhsdesign merged commit efef7df into 9.0 Sep 29, 2023
@mhsdesign mhsdesign deleted the task/NodeType.isOfType-allow-NodeTypeName branch September 29, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlubitz dlubitz dlubitz approved these changes

@nezaniel nezaniel nezaniel approved these changes

@bwaidelich bwaidelich bwaidelich approved these changes

@ahaeslich ahaeslich Awaiting requested review from ahaeslich

Assignees
No one assigned
Labels
9.0beta1 9.0
Projects
Neos 9.0 Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhsdesign @bwaidelich @nezaniel @dlubitz