Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP TASK: Reimplement NodeSearchService based on findDescendantNodes #4554

Closed
wants to merge 1 commit into from
Closed

WIP TASK: Reimplement NodeSearchService based on findDescendantNodes #4554

wants to merge 1 commit into from

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Sep 23, 2023 •
edited
Loading

Resolves: #3771

we also must not forget to use it in the neos ui and the places where it has been used previously.

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign marked this pull request as draft September 23, 2023 20:33
@github-actions github-actions bot added the 9.0 label Sep 23, 2023
@mhsdesign mhsdesign force-pushed the task/90-nodeSearchService branch from f37f302 to 6d67d46 Compare September 23, 2023 20:35
@mhsdesign mhsdesign mentioned this pull request Sep 23, 2023
Closed
mhsdesign
mhsdesign commented Sep 23, 2023
View reviewed changes
Neos.Neos/Classes/Domain/Service/NodeSearchService.php
}

public function findNodes(
Node|AbsoluteNodePath $entry,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Node|AbsoluteNodePath $entry,
NodeAggregateId|AbsoluteNodePath $entry,

@mhsdesign
Copy link
Member Author

we decided to remove this interface / and shallow implementation see #3771 (comment) for further information.

@mhsdesign mhsdesign closed this Oct 23, 2023
@mhsdesign mhsdesign deleted the task/90-nodeSearchService branch October 23, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TASK: re-implement NodeSearchService
1 participant
@mhsdesign