Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: cleanup (Asset usage) node address #4540

Merged
merged 2 commits into from
Sep 20, 2023
Merged

TASK: cleanup (Asset usage) node address #4540

merged 2 commits into from
Sep 20, 2023

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Sep 20, 2023 •
edited
Loading

subtask of #4341

The naming of the internal asset usage NodeAdress was adjusted - so people more likely import the right one.

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign requested review from bwaidelich and dlubitz and removed request for bwaidelich September 20, 2023 10:08
@mhsdesign mhsdesign force-pushed the task/cleanupNodeAddress branch from 9bf77c4 to 4f2a943 Compare September 20, 2023 10:09
@dlubitz
Copy link
Contributor

dlubitz commented Sep 20, 2023

Hehe, you noticed it yourself ;)

dlubitz
dlubitz approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@dlubitz dlubitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary, because ... thats what namespaces for. But I'm fine with it if it makes your life easier 😄

@mhsdesign
Copy link
Member Author

Yeah i just dont want to answer those questions in slack 😂 this thing is used like 2 time vs the other one will be public api.

bwaidelich
bwaidelich approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What Denny said..

@mhsdesign mhsdesign merged commit 73bf90f into 9.0 Sep 20, 2023
@mhsdesign mhsdesign deleted the task/cleanupNodeAddress branch September 20, 2023 10:30
@mhsdesign mhsdesign mentioned this pull request Sep 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlubitz dlubitz dlubitz approved these changes

@bwaidelich bwaidelich bwaidelich approved these changes

Assignees
No one assigned
Labels
9.0 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhsdesign @dlubitz @bwaidelich