Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Make Subtree immutable and remove Subtrees #4536

Merged
merged 4 commits into from
Oct 19, 2023
Merged

BUGFIX: Make Subtree immutable and remove Subtrees #4536

merged 4 commits into from
Oct 19, 2023

Conversation

bwaidelich
Copy link
Member

Fixes: #4535

@nezaniel nezaniel self-requested a review October 19, 2023 21:26
nezaniel
nezaniel approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@nezaniel nezaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, let's do it

@nezaniel nezaniel merged commit a6613f9 into 9.0 Oct 19, 2023
5 checks passed
@nezaniel nezaniel deleted the bugfix/4535-cleanup-subtree-implementation branch October 19, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsdesign mhsdesign mhsdesign approved these changes

@nezaniel nezaniel nezaniel approved these changes

Assignees
No one assigned
Labels
9.0 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup SubTree(s) value objects
3 participants
@bwaidelich @nezaniel @mhsdesign