Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Rename Afx Parsing Node to AfxNode #4528

Merged
merged 1 commit into from
Sep 19, 2023
Merged

TASK: Rename Afx Parsing Node to AfxNode #4528

merged 1 commit into from
Sep 19, 2023

Conversation

mhsdesign
Copy link
Member

This will make it easier to import the correct Neos CR Node - which you will want to use 100% of the time instead.

Resolves partially #4341

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign
TASK: Rename Afx Parsing Node to AfxNode
017e7f3 
This will make it easier to import the correct Neos CR Node - which you will want to use 100% of the time instead.

Resolves partially #4341
bwaidelich
bwaidelich approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

ahaeslich
ahaeslich approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@ahaeslich ahaeslich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed. was asked just yesterday which one should be used 😉

@mhsdesign mhsdesign merged commit 0538da9 into 9.0 Sep 19, 2023
5 checks passed
@mhsdesign mhsdesign deleted the task/renameAfxNodeParser branch September 19, 2023 11:03
@mhsdesign mhsdesign mentioned this pull request Sep 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahaeslich ahaeslich ahaeslich approved these changes

@bwaidelich bwaidelich bwaidelich approved these changes

@dlubitz dlubitz Awaiting requested review from dlubitz

@crydotsnake crydotsnake Awaiting requested review from crydotsnake

Assignees
No one assigned
Labels
9.0 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhsdesign @bwaidelich @ahaeslich