Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Add HTTP Status Code to Shortcuts #4490

Merged
merged 6 commits into from
Dec 29, 2023
Merged

FEATURE: Add HTTP Status Code to Shortcuts #4490

merged 6 commits into from
Dec 29, 2023

Conversation

pKallert
Copy link
Contributor

@pKallert pKallert commented Sep 8, 2023 •
edited
Loading

resolves #4410

According to the Poll here: #4410 (comment) we will be using a global Setting for the Shortcut instead of a nodeType.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@crydotsnake crydotsnake self-requested a review September 8, 2023 15:28
jonnitto
jonnitto approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@jonnitto jonnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine. (by reading)

dlubitz
dlubitz approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@dlubitz dlubitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thanks a lot for taking care

@kitsunet kitsunet merged commit 63725aa into neos:9.0 Dec 29, 2023
10 checks passed
@dlubitz dlubitz mentioned this pull request Dec 11, 2024
Closed
@dlubitz dlubitz added the Backport to 8.4 PRs which should be backported from Neos 9 to 8.4 label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlubitz dlubitz dlubitz approved these changes

@jonnitto jonnitto jonnitto approved these changes

@kitsunet kitsunet kitsunet approved these changes

@crydotsnake crydotsnake Awaiting requested review from crydotsnake

Assignees
No one assigned
Labels
9.0 Backport to 8.4 PRs which should be backported from Neos 9 to 8.4 Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FEATURE: Use something other than 303 for Neos Shortcut redirect
4 participants
@pKallert @kitsunet @jonnitto @dlubitz