!!! TASK Make NodeType::getPropertyType throw

[mhsdesign]

Previously - in Neos 8.x - NodeType::getPropertyType would fallback to "string" if no property is declared. This behaviour is hard to work with and an exception will be thrown instead.

NodeType schema has no property "undeclared-property" configured for the NodeType "Vendor:NodeType". Cannot read its type.

resolves #4477

Upgrade instructions

To migrate your code its recommended to check if a NodeType actually has the property before accessing its type as this could result in an exception.

- $type = $nodeType->getPropertyType('foo');
+ $type = $nodeType->hasProperty('foo') ? $nodeType->getPropertyType('foo') : 'string';

Optionally you could also use the newly introduced NodeType::hasProperty to clean up some a previous workaround to check if a node has a property:

- $exists = isset($nodeType->getProperties()['foo']);
+ $exists = $nodeType->hasProperty('foo');

Review instructions

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions