Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Use $nodeAggregateId->value redirect params in NodesController #4390

Merged

Conversation

grebaldi
Copy link
Contributor

@grebaldi grebaldi commented Jul 7, 2023

The problematic lines:

$this->redirect('show', null, null, [
'identifier' => $nodeAggregateId,
'workspaceName' => $workspaceName,
'dimensions' => $dimensions
]);

During testing of neos/neos-ui#3569, I stumbled over this one. The Router gets confused with the NodeAggregateId value object, so the resolution to ->value is needed here for the redirect to work.

After this fix, the UI should be able to switch dimensions smoothly :)

Copy link
Member

@skurfuerst skurfuerst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find :)

@skurfuerst skurfuerst merged commit 818d27c into neos:9.0 Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants