-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fluid templates using Nodes might certainly become impossible out of the box with Neos 9 #5023
Comments
To repair our backend module templates we would probably need to introduce a NodeInformation view helper or something, to get the nodetype and the label by node? |
After converting the workspace module to react + fusion (see: #4255) ... which fluid templates would need to be adjusted? |
usages:
|
beyond that fluid might currently work not at all? https://neos-project.slack.com/archives/C04PYL8H3/p1716467391919169 |
The |
... because we lack the corresponding eel helpers.
Currently we ship some
Neos.Node
helpers which replace field access that was previously directly accessible on the Node (in 8.3)We are conceptualising a translation layer, which would be made for EEL and would require a total different implementation for Fluid: #5022(Fluid has an extension point that we can leverage, the question is how much work are we willing to put into this to make theNeos\FluidAdaptor\Core\ViewHelper\TemplateVariableContainer
have special handling for nodes?)With the recent prs (#5020) and (#5021) fluid will not only have to adjust to
node.identifier
not working anymore but alsonode.nodeType
andnode.label
. This also affects ourselves in templates like these:neos-development-collection/Neos.Neos/Resources/Private/Partials/Module/Management/Workspaces/ContentChangeDiff.html
Lines 8 to 10 in 023a2fe
The price question is are we okay with Fluid integration not being a viable option anymore with Neos 9?
As long as Fluid only works with primitive types and the integration is done in Fusion, this will not be a problem, but anything further than this will be hard.
Also this affects custom backend modules as well as they might operate on nodes where we have no rector migration in place nor a translation layer.
Additionally there is a big regression in Fluid since 9.0 regarding
Neos.Fusion:Template
'sattributes
now being an array:#4885
And last but not least with #4654 the pages default
body
is changed too and no longer a template. If we want to continue supporting fluid we should provide a guide how to reset to 8.3 behaviour.So as far as i see it if we dont put some love into this fluid will be dead with Neos 9 and just a cosmetic dependency.
The text was updated successfully, but these errors were encountered: