9.0 Odd RebasableToOtherWorkspaceInterface commands AddDimensionShineThrough and MoveDimensionSpacePoint

[mhsdesign]

The commands AddDimensionShineThrough and MoveDimensionSpacePoint will implement the RebasableToOtherWorkspaceInterface via #4708

but they are not interested about the wordspaceName unlike the other commands but still operate on the contentstream ids.

This is the reason for the quirky $targetContentStreamId in createCopyForWorkspace.

Both commands will be used for structure adjustments and MoveDimensionSpacePoint will be available via flow content:moveDimensionSpacePoint

Despite being a little quirky they are both declared public api, so it would be hard to fix their api after Neos 9

Proposal:

• make them internal and fix them later and (and createCopyForWorkspace)
• fix it now to operate only on workspaces

[mhsdesign]

Todo: ask sebastian if these commands should also operate on the workspace name and enforce that the workspace is a root workspace (e.g. live)

additionally if this would be true we can also remove the RebasableToOtherWorkspaceInterface rebase functionality for those as they are never to be rebased.

[mhsdesign]

I dont know how blocking this is for the node identity, i looked at the code paths if we use anywhere node read models (which would lead us to require to pass the workspaceName, but so far i only found out that

AddDimensionShineThrough uses

• $subgraph->countNodes

MoveDimensionSpacePoint uses

• $subgraph->countNodes

both seem to be able to function without having the workspaceName as argument so maybe not that of a blocker as i though? or im late and i dont see it ... but i though there was a usage ...