Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of Neos WorkspaceName #4533

Closed
bwaidelich opened this issue Sep 19, 2023 · 0 comments · Fixed by #4534
Closed

Get rid of Neos WorkspaceName #4533

bwaidelich opened this issue Sep 19, 2023 · 0 comments · Fixed by #4534
Assignees
@bwaidelich
Labels
9.0beta1 9.0

Comments

@bwaidelich
Copy link
Member

bwaidelich commented Sep 19, 2023 •
edited by mhsdesign
Loading

Subtask of #4341

The \Neos\Neos\Domain\Model\WorkspaceName was added before the Neos.ContentRepository.Core package was introduced.

To avoid confusion, the WorkspaceName from the Neos\Neos namespace should be removed in favor of some static factory/builder for the Neos specific domain logic
@bwaidelich bwaidelich self-assigned this Sep 19, 2023
bwaidelich added a commit that referenced this issue Sep 19, 2023
@bwaidelich
BUGFIX: Remove Neos WorkspaceName
016fe55 
Fixes: #4533
This was referenced Sep 19, 2023
Merged
Merged
@mhsdesign mhsdesign moved this to Under Review 👀 in Neos 9.0 Release Board Sep 19, 2023
@mhsdesign mhsdesign moved this from Under Review 👀 to In Progress 🚧 in Neos 9.0 Release Board Sep 24, 2023
@mhsdesign mhsdesign moved this from In Progress 🚧 to Under Review 👀 in Neos 9.0 Release Board Sep 24, 2023
@github-project-automation github-project-automation bot moved this from Under Review 👀 to Done ✅ in Neos 9.0 Release Board Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwaidelich bwaidelich

Labels
9.0beta1 9.0
Projects
Neos 9.0 Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUGFIX: Remove Neos WorkspaceName neos/neos-development-collection
1 participant
@bwaidelich