4708 - add test cases for content stream closing

Neos.ContentRepository.BehavioralTests/Tests/Behavior/Features/ContentStreamClosing/01-CloseContentStream_ConstraintChecks.feature

@@ -0,0 +1,31 @@
+@contentrepository @adapters=DoctrineDBAL
+Feature: Constraint check test cases for closing content streams
+
+  Background:
+    Given using no content dimensions
+    And using the following node types:
+    """yaml
+    Neos.ContentRepository:Root: {}
+    """
+    And using identifier "default", I define a content repository
+    And I am in content repository "default"
+    And the command CreateRootWorkspace is executed with payload:
+      | Key                | Value           |
+      | workspaceName      | "live"          |
+      | newContentStreamId | "cs-identifier" |
+    And the graph projection is fully up to date
+
+  Scenario: Try to close a non-existing content stream:
+    And the command CloseContentStream is executed with payload and exceptions are caught:
+      | Key             | Value            |
+      | contentStreamId | "i-do-not-exist" |
+    Then the last command should have thrown an exception of type "ContentStreamDoesNotExistYet"
+
+  Scenario: Try to close a content stream that is already closed:
+    When the command CloseContentStream is executed with payload:
+      | Key             | Value           |
+      | contentStreamId | "cs-identifier" |
+    And the command CloseContentStream is executed with payload and exceptions are caught:
+      | Key             | Value           |
+      | contentStreamId | "cs-identifier" |
+    Then the last command should have thrown an exception of type "ContentStreamIsClosed"

Neos.ContentRepository.Core/Classes/Feature/ContentStreamCommandHandler.php

@@ -86,6 +86,7 @@ private function handleCloseContentStream(
     ): EventsToPublish {
         $this->requireContentStreamToExist($command->contentStreamId, $contentRepository);
         $expectedVersion = $this->getExpectedVersionOfContentStream($command->contentStreamId, $contentRepository);
+        $this->requireContentStreamToNotBeClosed($command->contentStreamId, $contentRepository);
         $streamName = ContentStreamEventStreamName::fromContentStreamId($command->contentStreamId)->getEventStreamName();
 
         return new EventsToPublish(

Neos.ContentRepository.Core/Classes/Feature/WorkspaceCommandHandler.php

@@ -365,7 +365,7 @@ private function handleRebaseWorkspace(
             CloseContentStream::create(
                 $workspace->currentContentStreamId,
             )
-        );
+        )->block();
 
         // - fork a new content stream
         $rebasedContentStreamId = $command->rebasedContentStreamId;

Neos.ContentRepository.TestSuite/Classes/Behavior/Features/Bootstrap/Features/ContentStreamClosing.php

@@ -43,4 +43,16 @@ public function theCommandCloseContentStreamIsExecutedWithPayload(TableNode $pay
 
         $this->lastCommandOrEventResult = $this->currentContentRepository->handle($command);
     }
+
+    /**
+     * @Given /^the command CloseContentStream is executed with payload and exceptions are caught:$/
+     */
+    public function theCommandCloseContentStreamIsExecutedWithPayloadAndExceptionsAreCaught(TableNode $payloadTable): void
+    {
+        try {
+            $this->theCommandCloseContentStreamIsExecutedWithPayload($payloadTable);
+        } catch (\Exception $exception) {
+            $this->lastCommandException = $exception;
+        }
+    }
 }