FEATURE: Make FormValues directly available in EmailFinisher template #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts the `EmailFinisher` so that formValues are available as placeholders directly (i.e. without requiring the `formValues.*` prefix). That allows the `EmailFinisher` to be used the same way as the `ConfirmationFinisher`. Note: This change is backwards compatible since the `formValues.` prefix is still supported. Resolves: #121
paavo
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
This works pretty good together with CKE5 placeholder insert plugin neos/form-builder#46
Thanks very much @bwaidelich 👍
|
Sorry for asking again 🙈 |
daniellienert
approved these changes
Aug 19, 2020
daniellienert
deleted the
feature/121-make-EmailFinisher-formValues-directly-accessible
branch
|
@paavo, done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the
EmailFinisherso that formValues are available as placeholdersdirectly (i.e. without requiring the
formValues.*prefix).That allows the
EmailFinisherto be used the same way as theConfirmationFinisher.Note: This change is backwards compatible since the
formValues.prefix isstill supported.
Resolves: #121