Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FormValues directly available in EmailFinisher template #121

Closed
bwaidelich opened this issue Aug 6, 2020 · 0 comments · Fixed by #122
Closed

Make FormValues directly available in EmailFinisher template #121

bwaidelich opened this issue Aug 6, 2020 · 0 comments · Fixed by #122
Assignees
@bwaidelich
Labels
enhancement

Comments

@bwaidelich
Copy link
Member

The ConfirmationFinisher replaces placeholders in the form {someFieldName}.
The EmailFinisher expects the form values to be prefixed with formValues., e.g. {formValues.someFieldName}.

This feature suggests to make form Values directly accessible as view variables in the EmailFinisher, too.

Note: The formValues.* format should still be supported to ensure greater backwards compatibility
@bwaidelich bwaidelich self-assigned this Aug 6, 2020
bwaidelich added a commit that referenced this issue Aug 6, 2020
@bwaidelich
FEATURE: Make FormValues directly available in EmailFinisher template
67bd922 
Adjusts the `EmailFinisher` so that formValues are available as placeholders
directly (i.e. without requiring the `formValues.*` prefix).

That allows the `EmailFinisher` to be used the same way as the `ConfirmationFinisher`.

Note: This change is backwards compatible since the `formValues.` prefix is
still supported.

Resolves: #121
@bwaidelich bwaidelich mentioned this issue Aug 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwaidelich bwaidelich

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEATURE: Make FormValues directly available in EmailFinisher template neos/form
1 participant
@bwaidelich