Merge pull request #133 from neos/bugfix/formviewhelper-fragment

BUGFIX: Set uri section in form viewhelper
neos · Mar 15, 2021 · 25b2f05 · 25b2f05
2 parents 31ec0ba + fa6444d
commit 25b2f05
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/Classes/ViewHelpers/FormViewHelper.php b/Classes/ViewHelpers/FormViewHelper.php
@@ -61,7 +61,7 @@ protected function getFormActionUri()
         $actionRequest = $this->controllerContext->getRequest();
         $uri = $actionRequest->getHttpRequest()->getUri();
         if ($this->hasArgument('section') && $this->arguments['section'] !== '') {
-            $uri->withFragment($this->hasArgument('section'));
+            $uri = $uri->withFragment($this->arguments['section']);
         }
         return (string)$uri;
     }

diff --git a/Tests/Unit/ViewHelpers/FormViewHelperTest.php b/Tests/Unit/ViewHelpers/FormViewHelperTest.php
@@ -82,6 +82,12 @@ public function getFormActionUriTests($requestUri, $sectionArgument, $expectedRe
         $mockActionRequest->expects($this->any())->method('getHttpRequest')->will($this->returnValue($mockHttpRequest));
 
         $mockUri = $this->getMockBuilder(Uri::class)->disableOriginalConstructor()->getMock();
+        $mockUri->expects($this->any())->method('withFragment')->will($this->returnCallback(function ($fragment) use ($requestUri, $mockUri) {
+            $newUri = explode('#', $requestUri)[0] . '#' . $fragment;
+            $modifiedMockUri = $this->getMockBuilder(Uri::class)->disableOriginalConstructor()->getMock();
+            $modifiedMockUri->expects($this->any())->method('__toString')->will($this->returnValue($newUri));
+            return $modifiedMockUri;
+        }));
         $mockUri->expects($this->any())->method('__toString')->will($this->returnValue($requestUri));
         $mockHttpRequest->expects($this->any())->method('getUri')->will($this->returnValue($mockUri));