-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Show all form fields in Placeholder-Insert #128
base: main
Are you sure you want to change the base?
Conversation
16d917d
to
1336c11
Compare
const node = this.props.nodesByContextPath[element.contextPath]; | ||
const childNodes = this.props.nodesByContextPath[element.contextPath].children; | ||
|
||
if (nodeTypeRegistry.isOfType(node.nodeType, 'Neos.Form.Builder:Mixin.PlaceholderInsert')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this wont work right away, due to the optimisations to the schema: neos/neos-ui#3677
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed this. It is required to add the nodetypes to the frontend configuration and it is possible to exclude all child nodes of a specific node type (which is useful for the options and validator collection because it is not required to list them all)
1336c11
to
9603b8e
Compare
9603b8e
to
d7a67b4
Compare
It is now also possible to list the fields of the further pages in the Placeholder-Insert |
- Create a frontend settings by which Form-Elements are shown in the placeholder insert - Load all form-elements recursively - Check if the elements are allowed to shown in the Placeholder-Insert-Dropdown by checking if they are not in the setting Resolves: neos#99
fields of further pages were not available in the placeholder-insert Related to: neos#99
d7a67b4
to
e816c29
Compare
@bwaidelich can you review this too? I already rebased the branch. |
@erkenes I'm not at all into the JavaScript details of the form builder, so unfortunately I can't provide a qualified review. I'll try to get someone else on it though |
As we prepared a new major version for Neos 9 in main, this would also target Neos 9 only. Shall we create a |
Resolves: #99