Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Show all form fields in Placeholder-Insert #128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

erkenes
Copy link

@erkenes erkenes commented Mar 2, 2023

  • Create a Mixin by which Form-Elements are shown in the placeholder insert
  • Load all form-elements recursively
  • Check if the elements are allowed to shown in the Placeholder-Insert-Dropdown by checking if they have the PlaceholderInsert-Mixin.

Resolves: #99

README.md Outdated Show resolved Hide resolved
@erkenes erkenes force-pushed the feature/ee-issue-99_2 branch from 16d917d to 1336c11 Compare March 4, 2024 09:18
@erkenes erkenes requested a review from crydotsnake March 4, 2024 09:33
@crydotsnake crydotsnake requested a review from mhsdesign March 4, 2024 18:11
const node = this.props.nodesByContextPath[element.contextPath];
const childNodes = this.props.nodesByContextPath[element.contextPath].children;

if (nodeTypeRegistry.isOfType(node.nodeType, 'Neos.Form.Builder:Mixin.PlaceholderInsert')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wont work right away, due to the optimisations to the schema: neos/neos-ui#3677

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this. It is required to add the nodetypes to the frontend configuration and it is possible to exclude all child nodes of a specific node type (which is useful for the options and validator collection because it is not required to list them all)

@erkenes erkenes force-pushed the feature/ee-issue-99_2 branch from 1336c11 to 9603b8e Compare March 5, 2024 16:15
@erkenes erkenes changed the title FEATURE: Create Mixin for Placeholder-Insert FEATURE: Show all form fields in Placeholder-Insert Mar 5, 2024
@erkenes erkenes force-pushed the feature/ee-issue-99_2 branch from 9603b8e to d7a67b4 Compare March 5, 2024 16:21
@erkenes
Copy link
Author

erkenes commented Mar 5, 2024

It is now also possible to list the fields of the further pages in the Placeholder-Insert

@crydotsnake crydotsnake requested a review from mhsdesign June 17, 2024 10:02
- Create a frontend settings by which Form-Elements
   are shown in the placeholder insert
- Load all form-elements recursively
- Check if the elements are allowed to shown in the
    Placeholder-Insert-Dropdown by checking if they
    are not in the setting

Resolves: neos#99
fields of further pages were not available in the
placeholder-insert

Related to: neos#99
@erkenes erkenes force-pushed the feature/ee-issue-99_2 branch from d7a67b4 to e816c29 Compare November 28, 2024 12:40
@erkenes
Copy link
Author

erkenes commented Nov 28, 2024

@bwaidelich can you review this too? I already rebased the branch.
We are using this changes in production a very long time now without any issues.

@bwaidelich
Copy link
Member

@bwaidelich can you review this too? I already rebased the branch.

@erkenes I'm not at all into the JavaScript details of the form builder, so unfortunately I can't provide a qualified review. I'll try to get someone else on it though

@dlubitz
Copy link
Contributor

dlubitz commented Dec 3, 2024

As we prepared a new major version for Neos 9 in main, this would also target Neos 9 only. Shall we create a 2.4 / 2.x branch for a new minor to use this feature before Neos 9.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placeholder-Insert: Only elements of the first level are displayed
6 participants