!!! TASK: Deprecate and replace ActionResponse in dispatcher
#3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2024
mhsdesign
force-pushed
the
task/makeActionResponseObsolete
branch
from
e50a1d9 to
cc3904f
Compare
mhsdesign
force-pushed
the
temporary-mvc-refactoring-target-branch
branch
from
57170ee to
f5b137f
Compare
mhsdesign
force-pushed
the
task/makeActionResponseObsolete
branch
from
cc3904f to
35d1008
Compare
mhsdesign
changed the base branch from
temporary-mvc-refactoring-target-branch
to
feature/dispatcher-returns-psr-responses
github-actions
bot
added
feature/dispatcher-returns-psr-responses
and removed
temporary-mvc-refactoring-target-branch
labels
mhsdesign
force-pushed
the
task/makeActionResponseObsolete
branch
from
a400e42 to
2711954
Compare
mhsdesign
force-pushed
the
task/makeActionResponseObsolete
branch
from
2711954 to
3b5d2bb
Compare
6 tasks
mhsdesign
force-pushed
the
task/makeActionResponseObsolete
branch
from
3b5d2bb to
b4b1d23
Compare
mhsdesign
commented
Feb 6, 2024
Neos.FluidAdaptor/Classes/Core/Widget/AbstractWidgetViewHelper.php
Outdated
Show resolved
Hide resolved
Neos.FluidAdaptor/Classes/Core/Widget/AbstractWidgetViewHelper.php
Outdated
Show resolved
Hide resolved
mhsdesign
changed the title
ActionResponse obsoleteActionResponse in dispatcher
mhsdesign
changed the title
ActionResponse in dispatcherActionResponse in dispatcher
|
TODO: Test with media module as it has pagination widget. -> ✅ |
mhsdesign
force-pushed
the
task/makeActionResponseObsolete
branch
from
1ed9617 to
ff2c7da
Compare
This will not open a memory stream
`replaceHttpResponse` is unsafe to use and has hard to tell behaviour. Instead, we up-merge the headers explicitly
mhsdesign
force-pushed
the
task/makeActionResponseObsolete
branch
from
ff2c7da to
3d32ace
Compare
mhsdesign
merged commit 415584b
into
neos:feature/dispatcher-returns-psr-responses
2 checks passed
mhsdesign
added a commit
to kitsunet/neos-development-collection
that referenced
this pull request
Mar 3, 2024
neos-bot
pushed a commit
to neos/neos
that referenced
this pull request
Sep 12, 2024
mhsdesign
added a commit
to mhsdesign/flow-development-collection
that referenced
this pull request
Oct 27, 2024
6 tasks
neos-bot
pushed a commit
to neos/flow
that referenced
this pull request
Oct 28, 2024
neos-bot
pushed a commit
to neos/flow
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3289 (Contains discussion about the reasoning).
will not be merged directly into 9.0 but included in this mvc overhaul pr: #3311
(original pr in christians fork kitsunet#5)