Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: minor behat test cleanup #3175

Merged
merged 7 commits into from
Sep 28, 2023
Merged

Task: minor behat test cleanup #3175

merged 7 commits into from
Sep 28, 2023

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Sep 24, 2023 •
edited
Loading

resolves partially #3169

Upgrade instructions

Review instructions

Instead of using neos/behat which installs selenium and stuff in another composer installation directory, we use behat as intended in the same composer installation.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked wit !!! and have upgrade-instructions

bwaidelich
bwaidelich reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice changes, thanks for taking care. Just a couple of inline comments

Neos.Flow/Tests/Behavior/behat.yml.dist Outdated Show resolved Hide resolved
Neos.Flow/Tests/Functional/Command/BehatTestHelper.php Show resolved Hide resolved
dlubitz
dlubitz reviewed Sep 26, 2023
View reviewed changes
Neos.Flow/composer.json Outdated Show resolved Hide resolved
mhsdesign
mhsdesign commented Sep 26, 2023
View reviewed changes
Neos.Flow/composer.json Outdated Show resolved Hide resolved
@mhsdesign
Copy link
Member Author

Okay @kitsunet liked this idea in slack

yes, very much in favor of simplifying that and using behat natively

so id count this as a review. @bwaidelich then lets merge this?

@dlubitz
Copy link
Contributor

dlubitz commented Sep 26, 2023 •
edited
Loading

I just don't get what the .composer.json is for. 🤷‍♂️

Edit: Ok, figured out. 👍

@kitsunet
Copy link
Member

Would you do a merge conflict fix, then I guess we could add this.

@mhsdesign mhsdesign merged commit ad4d67a into 9.0 Sep 28, 2023
@mhsdesign mhsdesign deleted the task/minorBehatTestCleanup branch September 28, 2023 08:42
@mhsdesign mhsdesign mentioned this pull request Sep 28, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlubitz dlubitz dlubitz approved these changes

@kitsunet kitsunet kitsunet approved these changes

@kdambekalns kdambekalns Awaiting requested review from kdambekalns

@fcool fcool Awaiting requested review from fcool

@bwaidelich bwaidelich Awaiting requested review from bwaidelich

Assignees
No one assigned
Labels
9.0 Task
Projects
Neos 9.0 Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhsdesign @dlubitz @kitsunet @bwaidelich