Skip to content

Commit

Permalink
TASK: Remove retry_attempt from subscriptions
Browse files Browse the repository at this point in the history
neos/neos-development-collection#5321 (comment)

> Anyways, I think with the removed retry strategy we should just get rid of the automatic retry altogether right now.
  It's quite unlikely that a retry suddenly works without other changes. So I'd be fully OK if it was only possible to manually retry failed subscriptions for 9.0
  • Loading branch information
mhsdesign committed Nov 23, 2024
1 parent 0f399d9 commit 848d8e5
Showing 1 changed file with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ public function setup(): void
(new Column('error_message', Type::getType(Types::TEXT)))->setNotnull(false),
(new Column('error_previous_status', Type::getType(Types::STRING)))->setNotnull(false)->setLength(32)->setPlatformOption('charset', 'ascii')->setPlatformOption('collation', 'ascii_general_ci'),
(new Column('error_trace', Type::getType(Types::TEXT)))->setNotnull(false),
(new Column('retry_attempt', Type::getType(Types::INTEGER)))->setNotnull(true),
(new Column('last_saved_at', Type::getType(Types::DATETIME_IMMUTABLE)))->setNotnull(true),
]);
$tableSchema->setPrimaryKey(['id']);
Expand Down Expand Up @@ -128,7 +127,6 @@ private static function toDatabase(Subscription $subscription): array
'error_message' => $subscription->error?->errorMessage,
'error_previous_status' => $subscription->error?->previousStatus?->name,
'error_trace' => $subscription->error?->errorTrace,
'retry_attempt' => $subscription->retryAttempt,
];
}

Expand All @@ -148,7 +146,6 @@ private static function fromDatabase(array $row): Subscription
assert(is_string($row['id']));
assert(is_string($row['status']));
assert(is_int($row['position']));
assert(is_int($row['retry_attempt']));
assert(is_string($row['last_saved_at']));
$lastSavedAt = DateTimeImmutable::createFromFormat('Y-m-d H:i:s', $row['last_saved_at']);
assert($lastSavedAt instanceof DateTimeImmutable);
Expand All @@ -158,7 +155,6 @@ private static function fromDatabase(array $row): Subscription
SubscriptionStatus::from($row['status']),
SequenceNumber::fromInteger($row['position']),
$subscriptionError,
$row['retry_attempt'],
$lastSavedAt,
);
}
Expand Down

0 comments on commit 848d8e5

Please sign in to comment.