-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation improvements #105
base: main
Are you sure you want to change the base?
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @neokd on Vercel. @neokd first needs to authorize it. |
@Bchass is this under hacktoberfest? |
@Bchass appreciation for your work, can you modify your code that user can give their own directory path so that they can run this code on any dataset. |
Not originally when I first started on these changes. But now I can see a new issue open regarding data validation. |
Yeah that's regarding generation of an entire report like format for each dataset.we'll slowly develop more on that issue into chunks so can work with any type of dataset |
Added the requested functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For printing the data store house we can use a existing python pip package which does this for us.
Package name? |
There are multiple terminal enhancement packages. few other I got from search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
@Gladwin001 , @Bchass anything more to add on this PR? |
I'm all set on my end |
@Bchass Thanks for all your contribution 🥇 🌟 |
Description
Cleaned up the code to make it more readable and minimized some of the repetitiveness that existed. Renamed the file from
Main.py
tovalidate.py
. This also includes the ability for the terminal to ask which file you would like to analyze and then automatically opens the report generated.Related Issues
N/A
Changes Made
open_report()
file_type()
toanalyze_file()
and cleaned this file up a good amountwith open(report_file, 'a') as file:
withopen_report()
and a f-string for easier readabilitymain()
at the bottom of the file that now handles the terminal workflow and opening the report automaticallyScreenshots (if applicable)
Checklist
Please review and check the following before submitting your pull request:
Additional Notes
N/A