Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation improvements #105

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

Bchass
Copy link
Contributor

@Bchass Bchass commented Oct 1, 2023

Description

Cleaned up the code to make it more readable and minimized some of the repetitiveness that existed. Renamed the file from Main.py to validate.py. This also includes the ability for the terminal to ask which file you would like to analyze and then automatically opens the report generated.

Related Issues

N/A

Changes Made

  • Added open_report()
  • Renamed file_type() to analyze_file() and cleaned this file up a good amount
  • Replaced all with open(report_file, 'a') as file: with open_report() and a f-string for easier readability
  • Created main() at the bottom of the file that now handles the terminal workflow and opening the report automatically

Screenshots (if applicable)

Screenshot 2023-10-01 at 7 29 04 PM

Checklist

Please review and check the following before submitting your pull request:

  • I have followed the project's coding conventions and guidelines
  • I have tested my changes thoroughly
  • I have added/updated relevant documentation
  • My code follows best practices and is easy to understand
  • I have added necessary test cases (if applicable)
  • All existing tests are passing
  • My changes do not introduce any new warnings or errors

Additional Notes

N/A

@vercel
Copy link

vercel bot commented Oct 1, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @neokd on Vercel.

@neokd first needs to authorize it.

@Bchass
Copy link
Contributor Author

Bchass commented Oct 2, 2023

Screenshot 2023-10-01 at 8 23 32 PM

Gave it more of a pleasant looking prompt

@neokd
Copy link
Owner

neokd commented Oct 2, 2023

@Bchass is this under hacktoberfest?

@Gladwin001
Copy link
Collaborator

@Bchass appreciation for your work, can you modify your code that user can give their own directory path so that they can run this code on any dataset.

@Bchass
Copy link
Contributor Author

Bchass commented Oct 2, 2023

@Bchass is this under hacktoberfest?

Not originally when I first started on these changes. But now I can see a new issue open regarding data validation.

@neokd
Copy link
Owner

neokd commented Oct 2, 2023

Yeah that's regarding generation of an entire report like format for each dataset.we'll slowly develop more on that issue into chunks so can work with any type of dataset

@Bchass
Copy link
Contributor Author

Bchass commented Oct 2, 2023

@Bchass appreciation for your work, can you modify your code that user can give their own directory path so that they can run this code on any dataset.

Added the requested functionality

Copy link
Contributor

@VigneshRamanathan101 VigneshRamanathan101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For printing the data store house we can use a existing python pip package which does this for us.

@Bchass
Copy link
Contributor Author

Bchass commented Oct 8, 2023

For printing the data store house we can use a existing python pip package which does this for us.

Package name?

@VigneshRamanathan101
Copy link
Contributor

For printing the data store house we can use a existing python pip package which does this for us.

Package name?

There are multiple terminal enhancement packages.
https://pypi.org/project/art/ - this will help you create a similar visualization you implemented using print.

few other I got from search
https://github.com/Textualize/rich/tree/master#rich-library
https://pypi.org/project/simple-term-menu/

Copy link
Contributor

@VigneshRamanathan101 VigneshRamanathan101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@neokd
Copy link
Owner

neokd commented Oct 16, 2023

@Gladwin001 , @Bchass anything more to add on this PR?

@Bchass
Copy link
Contributor Author

Bchass commented Oct 16, 2023

I'm all set on my end

@neokd
Copy link
Owner

neokd commented Oct 17, 2023

@Bchass Thanks for all your contribution 🥇 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants