Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: deviation in snippet select in the first column #5104

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

A4-Tacks
Copy link
Contributor

@A4-Tacks A4-Tacks commented Aug 5, 2024

close neoclide/coc-snippets#347

in INSERT mode run <cmd>call coc#snippet#select(#{line:0,character:1}, #{line:0,character:1}, "a")<cr>
settings: selection=inclusive

expect select first column, but it selected second column

@A4-Tacks A4-Tacks force-pushed the first-column-snippet-select branch from 7e6633e to 2341057 Compare August 5, 2024 10:42
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (c5ffbb3) to head (2341057).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5104      +/-   ##
==========================================
- Coverage   98.47%   98.45%   -0.02%     
==========================================
  Files         273      273              
  Lines       26088    26088              
  Branches     5389     5389              
==========================================
- Hits        25689    25686       -3     
- Misses        239      241       +2     
- Partials      160      161       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fannheyward fannheyward merged commit 53e21a9 into neoclide:master Aug 28, 2024
3 of 4 checks passed
@A4-Tacks A4-Tacks deleted the first-column-snippet-select branch August 28, 2024 13:09
fannheyward added a commit that referenced this pull request Sep 2, 2024
9c25f2f fix(typings): getDocument return type. (#5132)
d4ff928 feat(language-client): modify log time format (#5130)
53e21a9 fix(snippet): deviation in snippet select in the first column (#5104)
0e6a8c7 feat(codeLens): add codeLens.display (#5129)
704295e fix(handler): correct current winid (#5128)
aabfc23 fix: ignore failed config file reads (#5118)
56ea360 feat: expose more properties quick list (#5114)
37f98a1 feat(util): adjust to vim's Patch 9.1.327 (#5122)
80e9f1b chore(package): upgrade micromatch (#5127)
98fa66a chore(packages): lock ESLint versions for now (#5108)
bf3d1f6 Add `coc.preferences.formatterExtension` configuration (#5102)
38697bc chore(handle): typo toggle inlayHint (#5105)
@fannheyward
Copy link
Member

@all-contributors please add @A4-Tacks for code.

Copy link
Contributor

@fannheyward

I've put up a pull request to add @A4-Tacks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong variable selection position at the beginning of the line
2 participants