fix(workspace): add missing interface to renamed method #5032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method asRelativePath was probably renamed in the past, however there are extensions such as coc-java which are using the method named asRelativePath expose the method in the typings api
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5032 +/- ##
==========================================
- Coverage 98.51% 98.50% -0.01%
==========================================
Files 273 273
Lines 26072 26073 +1
Branches 5389 5389
==========================================
- Hits 25684 25683 -1
- Misses 228 230 +2
Partials 160 160 ☔ View full report in Codecov by Sentry. |
fannheyward
approved these changes
Jun 6, 2024
fannheyward
changed the title
fannheyward
added a commit
that referenced
this pull request
Jul 4, 2024
5663297 feat(core): support NVIM_APPNAME (#5073) bdf2fa4 fix(coc#has_item_selected): check pum visible (#5067) b37b3e0 feat(coc#pum#has_item_selected) (#5064) bdfd169 feat(inlayHint): add `inlayHint.position` configuration e4abae7 feat(typings): more options in NvimFloatOptions (#5058) b3cbba4 feat(extension): allow `CocUpdate` UI open in tab (#5050) 3a0980f chore(packages): eslint related (#5048) 79ccfea fix(diagnostic): stack hl groups (#5046) 974b9c8 fix(package): npm audit fix (#5041) c054573 fix(workspace): add missing interface to renamed method (#5032) ba3c0a9 feat!: increase minimum vim/nvim versions (#5026)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method asRelativePath was probably renamed in the past, however there are extensions such as coc-java which are using the method named asRelativePath expose the method in the workspace api, as it is already exposed in the typings api.