Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neo4j 8.x and Core 7.x support #14

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Neo4j 8.x and Core 7.x support #14

wants to merge 7 commits into from

Conversation

ProGM
Copy link
Member

@ProGM ProGM commented Aug 31, 2016

It's pretty much a refactor to support the new neo4j-core API and the ActiveNode integration.

It keeps support for the old neo4j-core API. (see old_api_spec.rb)
It implements the spatial methods monkey patching the HTTP adaptor of the new cypher API.
I think we should create a new major version for this, like 2.x

Pings: @subvertallchris @cheerfulstoic

ProGM added 5 commits August 31, 2016 17:37
* master:
  Improved compatibility with neo4j 2.1.8
  Typo.
  Another try with travis.
  Fix travis envs.
  Fix JDK and jruby details.
  Added error handling for http requests.
  Trying older neo4j versions.
  Yet another travis setup.
  Excluding neo4j 8 from current version requirements
  Trying another travis setup.
@pmackay pmackay mentioned this pull request Feb 8, 2017
@pmackay
Copy link

pmackay commented Feb 24, 2017

@ProGM I think neo4jrb_spatial.gemspec needs updating to require a more recent version of the neo4j-core gem. Might you be able to add that change?

@cheerfulstoic
Copy link
Contributor

I see that the gemspec specific excludes neo4j 8 and neo4j-core 7. Were there incompatibilities?

@cheerfulstoic
Copy link
Contributor

I don't use this gem, but it might be worth forking the repo and changing the gemspec to remove that restriction and see how things work

@pmackay
Copy link

pmackay commented Feb 27, 2017

@cheerfulstoic this branch is intended to work with neo4j v8 but it required a version less than that. I had tried a local fork a few days back and it worked, have now got the change here pmackay@b6ff9ca

@cheerfulstoic
Copy link
Contributor

Ah, I understand now! Just pushed a change to the gemspec to remove the restriction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants