New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http driver config 6.1.x #274

Open

brucek wants to merge 13 commits into neo4jrb:6.1.x from brucek:http_driver_config_6.1.x

Contributor

brucek commented Nov 18, 2016

Fixes #272

This pull introduces/changes:

adds an :http_adaptor option to CypherSession::Adaptors::HTTP.new for Faraday adaptor

Pings:
@cheerfulstoic
@subvertallchris

brucek added 2 commits

November 17, 2016 18:32


          Allow :http_adapter creation option for http CypherSession

635099a


          Harmonizing adaptor spelling

0586a56

coveralls commented Nov 18, 2016 •

edited

Loading

Coverage increased (+11.8%) to 93.449% when pulling 0586a56 on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.


          Fixing rubocop

a5d63ff

coveralls commented Nov 18, 2016 •

edited

Loading

Coverage increased (+11.8%) to 93.449% when pulling a5d63ff on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.


          Fixing rubocop

62ea256

coveralls commented Nov 18, 2016 •

edited

Loading

Coverage increased (+11.8%) to 93.449% when pulling 62ea256 on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

2 similar comments

coveralls commented Nov 18, 2016

Coverage increased (+11.8%) to 93.449% when pulling 62ea256 on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

coveralls commented Nov 18, 2016

Coverage increased (+11.8%) to 93.449% when pulling 62ea256 on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.


          Trying to fix JRuby

75ff92e

coveralls commented Nov 18, 2016 •

edited

Loading

Coverage decreased (-0.03%) to 81.599% when pulling 75ff92e on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.


          Fixing specs

c5e4953

coveralls commented Nov 18, 2016 •

edited

Loading

Coverage decreased (-0.04%) to 81.595% when pulling c5e4953 on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

1 similar comment

coveralls commented Nov 18, 2016

Coverage decreased (-0.04%) to 81.595% when pulling c5e4953 on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

brucek added 2 commits

November 17, 2016 22:34


          Fixing gem dependency

16815fc


          Hopefully actually fixing the Gemfile dependency issue

4a2e878

coveralls commented Nov 18, 2016 •

edited

Loading

Coverage decreased (-0.04%) to 81.595% when pulling 16815fc on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

coveralls commented Nov 18, 2016 •

edited

Loading

Coverage decreased (-0.04%) to 81.595% when pulling 4a2e878 on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

3 similar comments

coveralls commented Nov 18, 2016

Coverage decreased (-0.04%) to 81.595% when pulling 4a2e878 on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

coveralls commented Nov 18, 2016

Coverage decreased (-0.04%) to 81.595% when pulling 4a2e878 on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

coveralls commented Nov 18, 2016

Coverage decreased (-0.04%) to 81.595% when pulling 4a2e878 on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.


          Allowing http_adaptor key as either string or symbol

c077648

coveralls commented Nov 18, 2016 •

edited

Loading

Coverage increased (+0.005%) to 81.636% when pulling c077648 on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

2 similar comments

coveralls commented Nov 18, 2016

Coverage increased (+0.005%) to 81.636% when pulling c077648 on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

coveralls commented Nov 18, 2016

Coverage increased (+0.005%) to 81.636% when pulling c077648 on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.


          Fully test the CypherSession connections

92e2816

coveralls commented Nov 18, 2016 •

edited

Loading

Coverage increased (+0.03%) to 81.665% when pulling 92e2816 on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.


          Fixing Rubocop and JRuby gem dependency

c40f8e2

coveralls commented Nov 18, 2016 •

edited

Loading

Coverage increased (+11.8%) to 93.382% when pulling c40f8e2 on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.


          Figured out how to properly use .rubocop_todo.yml

9f0debc

coveralls commented Nov 18, 2016 •

edited

Loading

Coverage increased (+11.8%) to 93.382% when pulling 9f0debc on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.


          Moving to faraday_options

5c5aa6b

coveralls commented Nov 22, 2016 •

edited

Loading

Coverage increased (+11.8%) to 93.389% when pulling 5c5aa6b on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

8 similar comments

coveralls commented Nov 22, 2016

Coverage increased (+11.8%) to 93.389% when pulling 5c5aa6b on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

coveralls commented Nov 22, 2016

Coverage increased (+11.8%) to 93.389% when pulling 5c5aa6b on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

coveralls commented Nov 22, 2016

Coverage increased (+11.8%) to 93.389% when pulling 5c5aa6b on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

coveralls commented Nov 22, 2016

Coverage increased (+11.8%) to 93.389% when pulling 5c5aa6b on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

coveralls commented Nov 22, 2016

Coverage increased (+11.8%) to 93.389% when pulling 5c5aa6b on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

coveralls commented Nov 22, 2016

Coverage increased (+11.8%) to 93.389% when pulling 5c5aa6b on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

coveralls commented Nov 22, 2016

Coverage increased (+11.8%) to 93.389% when pulling 5c5aa6b on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

coveralls commented Nov 22, 2016 •

edited

Loading

Coverage increased (+11.8%) to 93.389% when pulling 5c5aa6b on brucek:http_driver_config_6.1.x into 0da8758 on neo4jrb:6.1.x.

cheerfulstoic mentioned this pull request

Allow Faraday init params to be passed to HTTP adaptor #288

Merged

Contributor

cheerfulstoic commented Mar 16, 2017

I'm not sure if you're on 7.0.x yet, but I just released 7.0.8 which allows you to configure faraday's adaptor with a faraday_configurator option. See the documentation here:

http://neo4jrb.readthedocs.io/en/8.0.x/Setup.html#configuring-faraday

That's the Rails configuration, obviously, but it all ends up as the faraday_configurator option passed into the HTTP adaptor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet