Merge pull request #486 from technige/1.6-driver-logging

Better logging for Driver creation
neo4j · Apr 16, 2018 · dda3e89 · dda3e89
2 parents 90f9672 + a6ff034
commit dda3e89
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/driver/src/main/java/org/neo4j/driver/internal/DriverFactory.java b/driver/src/main/java/org/neo4j/driver/internal/DriverFactory.java
@@ -158,7 +158,10 @@ protected InternalDriver createDirectDriver( SecurityPlan securityPlan, BoltServ
     {
         ConnectionProvider connectionProvider = new DirectConnectionProvider( address, connectionPool );
         SessionFactory sessionFactory = createSessionFactory( connectionProvider, retryLogic, config );
-        return createDriver( securityPlan, sessionFactory, metrics, config );
+        InternalDriver driver = createDriver(securityPlan, sessionFactory, metrics, config);
+        Logger log = config.logging().getLog( Driver.class.getSimpleName() );
+        log.info( "Direct driver instance %s created for server address %s", driver, address.toString() );
+        return driver;
     }
 
     /**
@@ -176,7 +179,10 @@ protected InternalDriver createRoutingDriver( SecurityPlan securityPlan, BoltSer
         ConnectionProvider connectionProvider = createLoadBalancer( address, connectionPool, eventExecutorGroup,
                 config, routingSettings );
         SessionFactory sessionFactory = createSessionFactory( connectionProvider, retryLogic, config );
-        return createDriver( securityPlan, sessionFactory, metrics, config );
+        InternalDriver driver = createDriver(securityPlan, sessionFactory, metrics, config);
+        Logger log = config.logging().getLog( Driver.class.getSimpleName() );
+        log.info( "Routing driver instance %s created for server address %s", driver, address.toString() );
+        return driver;
     }
 
     /**

diff --git a/driver/src/main/java/org/neo4j/driver/internal/InternalDriver.java b/driver/src/main/java/org/neo4j/driver/internal/InternalDriver.java
@@ -47,7 +47,6 @@ public class InternalDriver implements Driver
         this.sessionFactory = sessionFactory;
         this.metrics = metrics;
         this.log = logging.getLog( Driver.class.getSimpleName() );
-        log.info( "Driver instance %s created", this );
     }
 
     @Override