Fix flaky boltkit test

`GraphDatabaseTest#boltSchemeShouldInstantiateDirectDriver()` did not properly close driver which resulted in sporadically failing Windows builds.
neo4j · May 23, 2017 · 6d818ba · 6d818ba
1 parent ddc8cc5
commit 6d818ba
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/driver/src/test/java/org/neo4j/driver/v1/GraphDatabaseTest.java b/driver/src/test/java/org/neo4j/driver/v1/GraphDatabaseTest.java
@@ -50,7 +50,10 @@ public void boltSchemeShouldInstantiateDirectDriver() throws Exception
 
         // Then
         assertThat( driver, is( directDriver() ) );
-        server.exit();
+
+        // Finally
+        driver.close();
+        assertThat( server.exitStatus(), equalTo( 0 ) );
     }
 
     @Test

diff --git a/driver/src/test/java/org/neo4j/driver/v1/util/StubServer.java b/driver/src/test/java/org/neo4j/driver/v1/util/StubServer.java
@@ -79,7 +79,7 @@ public int exitStatus() throws InterruptedException, ForceKilled
         }
     }
 
-    public void exit() throws InterruptedException
+    private void exit() throws InterruptedException
     {
         process.destroy();
         process.waitFor();