Add deprecations and FileSeedProvider #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jackwaudby
commented
Oct 24, 2024
•
jackwaudby
commented
- S3SeedProvider is deprecated as of 5.26
- FileSeedProvider added in 5.26
- file: is deprecated for URLConnectionProvider as of 5.26
- Reorder providers putting S3SeedProvider last
NataliaIvakina
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
@jackwaudby, thank you! This looks good. I added a few suggestions to be in line with the rest of the manual.
Please, do not merge this PR! We have to publish the 5.25 docs first.
Co-authored-by: NataliaIvakina <[email protected]>
Co-authored-by: NataliaIvakina <[email protected]>
Co-authored-by: NataliaIvakina <[email protected]>
Co-authored-by: NataliaIvakina <[email protected]>
Co-authored-by: NataliaIvakina <[email protected]>
Co-authored-by: NataliaIvakina <[email protected]>
Co-authored-by: NataliaIvakina <[email protected]>
Co-authored-by: NataliaIvakina <[email protected]>
|
@NataliaIvakina thank you, I've committed the suggestions. Ok sure thing, I will leave it up to you to hit merge when the time comes |
|
@NataliaIvakina I've pushed up a change that adds headings for the seed providers so @mnd999 can link to them directly from the deprecation note in his PR. |
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
This was referenced Oct 31, 2024
renetapopova
added a commit
that referenced
this pull request
Nov 1, 2024
Also add a note about deprecated store formats We may need to add some more details about the deprecations once clustering get to look at it. Depends on: #1909 --------- Co-authored-by: Reneta Popova <[email protected]>
JPryce-Aklundh
added a commit
to neo4j/docs-cypher
that referenced
this pull request
Nov 11, 2024
* Deprecate seedCredentials and seedConfig options without a (language) replacement. * Deprecate standard and high_limit store formats - [x] Still waiting on information from cluster as to how to do seeding from buckets now. Depends on: neo4j/docs-operations#1909 --------- Co-authored-by: Therese Magnusson <[email protected]> Co-authored-by: Jens Pryce-Åklundh <[email protected]>
JPryce-Aklundh
added a commit
to neo4j/docs-cypher
that referenced
this pull request
Nov 11, 2024
* Deprecate seedCredentials and seedConfig options without a (language) replacement. * Deprecate standard and high_limit store formats - [x] Still waiting on information from cluster as to how to do seeding from buckets now. Depends on: neo4j/docs-operations#1909 --------- Co-authored-by: Therese Magnusson <[email protected]> Co-authored-by: Jens Pryce-Åklundh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.