Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example of property-based access control using temporal value #1887

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Example of property-based access control using temporal value #1887

merged 6 commits into from
Oct 31, 2024

Conversation

HannesSandberg
Copy link
Contributor

@HannesSandberg HannesSandberg commented Oct 21, 2024 •
edited
Loading

cypher manual PR

@renetapopova renetapopova self-requested a review October 21, 2024 09:30
renetapopova
renetapopova reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @HannesSandberg. I have two minor suggestions. For which version is this PR?

modules/ROOT/pages/authentication-authorization/property-based-access-control.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/authentication-authorization/property-based-access-control.adoc Outdated Show resolved Hide resolved
@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@HannesSandberg
Copy link
Contributor Author

For which version is this PR?

@renetapopova Thanks for reviewing. This feature was merged last week so will be for the next release, which would be 5.26 right?

@renetapopova
Copy link
Contributor

For which version is this PR?

@renetapopova Thanks for reviewing. This feature was merged last week so will be for the next release, which would be 5.26 right?

yes, thanks!

Hunterness
Hunterness reviewed Oct 25, 2024
View reviewed changes
modules/ROOT/pages/authentication-authorization/property-based-access-control.adoc
[source, syntax, role="noheader"]
----
SHOW ROLE regularUsers PRIVILEGES AS REVOKE COMMANDS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a lot of things granted to that role but if this page isn't being tested I guess just returning the one you want to show is fine 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I did want to show the explicit case and not everything that was granted to the role

@renetapopova renetapopova merged commit f07e88b into neo4j:dev Oct 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil198 phil198 phil198 left review comments

@renetapopova renetapopova renetapopova approved these changes

@Hunterness Hunterness Hunterness approved these changes

Assignees

@Hunterness Hunterness

Labels
5.26 team-cypher-operations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HannesSandberg @neo-technology-commit-status-publisher @renetapopova @Hunterness @phil198