Describe the semi-automated procedure that migrates Discovery Service V1 to V2.

[akarasavov]

Before publishing the docs the internal prefix from the procedure path needs to be removed

[nick-giles-neo]

One small tweak as a consequence of the re-ordering, then I'd like @NataliaIvakina to give the OK on the section names, then I'm happy.

[NataliaIvakina]

We also need to add this new procedure to the procedures' list on the https://neo4j.com/docs/operations-manual/current/reference/procedures/

[NataliaIvakina]

However, I don't see this new procedure in the procedure.json file in the code.

BTW, do you know that arguments' descriptions have to be written in a user-friendly way now? See https://github.com/neo-technology/neo4j/pull/26625

[NataliaIvakina]

'on this server' or 'on this cluster'?
You say 'on this server' here but the procedure is for moving the entire cluster.

[akarasavov]

This procedure CALL dbms.cluster.showParallelDiscoveryState(); is used to check the state of a single member. So we need to use the term server. This procedure CALL internal.dbms.cluster.moveToNextDiscoveryVersion() moves several members to the next discovery version

[akarasavov]

I think your question is: why do we query the discovery state (CALL dbms.cluster.showParallelDiscoveryState()) of a single server after calling CALL internal.dbms.cluster.moveToNextDiscoveryVersion() instead of checking the state of other servers?

Our goal is to minimize the number of steps the DB admin needs to take to migrate from V1_ONLY to V2_ONLY. We are quite confident that if the state of a single server matches (i.e., showParallelDiscoveryState returns 'Matching'), the states of the other servers are also likely to match. This is the reason why we don't ask db-admins to check the state of other servers.

We can add the following explanation to clarify why we query only a single server after executing moveToNextDiscoveryVersion

[akarasavov]

However, I don't see this new procedure in the procedure.json file in the code.

BTW, do you know that arguments' descriptions have to be written in a user-friendly way now? See neo-technology/neo4j#26625

[neo-technology-commit-status-publisher]

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

[neo-technology-commit-status-publisher]

This PR includes documentation updates
View the updated docs at https://neo4j-docs-operations-1861.surge.sh

Updated pages:

• Cluster server discovery
• Procedures

[akarasavov]

Prodecures testing fails mismatch for quarantineDatabase.

AssertionError: Mismatch in signature for procedure dbms.quarantineDatabase.
== Docs ==
dbms.quarantineDatabase(databaseName :: STRING, setStatus :: BOOLEAN, reason = No reason given :: STRING) :: (databaseName :: STRING, quarantined :: BOOLEAN, result :: STRING)
== Neo4j ==
dbms.quarantineDatabase(databaseName :: STRING, setStatus :: BOOLEAN, reason = No reason given :: STRING, wipeMode = DO_NOT_WIPE :: STRING) :: (databaseName :: STRING, quarantined :: BOOLEAN, result :: STRING)
operations/test-procedures.py:75: in test_settings
    assert docs_procedures[name]['signature'] == procedure['signature'], \
E   AssertionError: Mismatch in signature for procedure dbms.quarantineDatabase.
E   == Docs ==
E   dbms.quarantineDatabase(databaseName :: STRING, setStatus :: BOOLEAN, reason = No reason given :: STRING) :: (databaseName :: STRING, quarantined :: BOOLEAN, result :: STRING)
E   == Neo4j ==
E   dbms.quarantineDatabase(databaseName :: STRING, setStatus :: BOOLEAN, reason = No reason given :: STRING, wipeMode = DO_NOT_WIPE :: STRING) :: (databaseName :: STRING, quarantined :: BOOLEAN, result :: STRING)

I didn't change anything in the area of quarantineDatabase so it is interesting why it fails :)

[NataliaIvakina]

Prodecures testing fails mismatch for quarantineDatabase.

AssertionError: Mismatch in signature for procedure dbms.quarantineDatabase.
== Docs ==
dbms.quarantineDatabase(databaseName :: STRING, setStatus :: BOOLEAN, reason = No reason given :: STRING) :: (databaseName :: STRING, quarantined :: BOOLEAN, result :: STRING)
== Neo4j ==
dbms.quarantineDatabase(databaseName :: STRING, setStatus :: BOOLEAN, reason = No reason given :: STRING, wipeMode = DO_NOT_WIPE :: STRING) :: (databaseName :: STRING, quarantined :: BOOLEAN, result :: STRING)
operations/test-procedures.py:75: in test_settings
    assert docs_procedures[name]['signature'] == procedure['signature'], \
E   AssertionError: Mismatch in signature for procedure dbms.quarantineDatabase.
E   == Docs ==
E   dbms.quarantineDatabase(databaseName :: STRING, setStatus :: BOOLEAN, reason = No reason given :: STRING) :: (databaseName :: STRING, quarantined :: BOOLEAN, result :: STRING)
E   == Neo4j ==
E   dbms.quarantineDatabase(databaseName :: STRING, setStatus :: BOOLEAN, reason = No reason given :: STRING, wipeMode = DO_NOT_WIPE :: STRING) :: (databaseName :: STRING, quarantined :: BOOLEAN, result :: STRING)

I didn't change anything in the area of quarantineDatabase so it is interesting why it fails :)

It failed because a new option was added to the quarantine procedure. We can ignore this failure. We have another PR to cover changes made to the quarantine procedure.

[NataliaIvakina]

@akarasavov, since this PR is for the 5.26 release, please do not merge it now. We'll publish the 5.25 docs first and then merge everything related to 5.26.