Fix duplicated entry for page_cache.page_cancelled_faults metric
#1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a duplicated entry for that metric, with the only difference being one has the description spelled `canceled` and the other one `cancelled`. I merged both into the first entry just because because that matches the order of the metrics in the code-base.
|
Spotted this while reading the docs. I think this is my first PR here, so let me know if I did everything correctly with labels and stuff :) |
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
renetapopova
requested review from
NataliaIvakina
and removed request for
renetapopova
NataliaIvakina
approved these changes
Jan 8, 2024
|
This PR needs to be cherry-picked to 5.x if you haven't already. |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a duplicated entry for that metric, with the only difference being one has the description spelled
canceledand the other onecancelled.I merged both into the first entry just because because that matches the order of the metrics in the code-base.