Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct max label id #1176

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

emmaholmbergohlsson
Copy link
Contributor

2^32 labels has never actually been supported,
anything over 2^31 would fail with an integer overflow.

2^32 labels has never actually been supported,
anything over 2^31 would fail with an integer overflow.
@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@emmaholmbergohlsson
Copy link
Contributor Author

Corresponding code change https://github.com/neo-technology/neo4j/pull/23063

@renetapopova renetapopova self-requested a review November 10, 2023 14:02
Copy link
Contributor

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing them, @emmaholmbergohlsson!

@emmaholmbergohlsson
Copy link
Contributor Author

No problem. Can I leave merging and cherry-picking to you @renetapopova or should I do something more?

@renetapopova
Copy link
Contributor

No problem. Can I leave merging and cherry-picking to you @renetapopova or should I do something more?

I'll do it.

@renetapopova renetapopova merged commit c6cb50a into neo4j:dev Nov 10, 2023
2 checks passed
@renetapopova
Copy link
Contributor

@emmaholmbergohlsson, is this change applicable to 5.15 or to the current version? The docs are currently on 5.13.

@emmaholmbergohlsson
Copy link
Contributor Author

@emmaholmbergohlsson, is this change applicable to 5.15 or to the current version? The docs are currently on 5.13.

The real limit has always been 2^31, so it is applicable to current version as well.
My code change just makes it explicit in the code to give a nicer experience to any customers coming up to that limit

renetapopova pushed a commit to renetapopova/docs-operations that referenced this pull request Nov 10, 2023
2^32 labels has never actually been supported,
anything over 2^31 would fail with an integer overflow.
renetapopova pushed a commit to renetapopova/docs-operations that referenced this pull request Nov 10, 2023
2^32 labels has never actually been supported,
anything over 2^31 would fail with an integer overflow.
renetapopova added a commit that referenced this pull request Nov 10, 2023
2^32 labels has never actually been supported,
anything over 2^31 would fail with an integer overflow.

Cherry-picked from #1176

Co-authored-by: emmaholmbergohlsson <[email protected]>
renetapopova added a commit that referenced this pull request Nov 10, 2023
2^32 labels has never actually been supported,
anything over 2^31 would fail with an integer overflow.
Cherry-picked from #1176

Co-authored-by: emmaholmbergohlsson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants