-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct max label id #1176
Correct max label id #1176
Conversation
2^32 labels has never actually been supported, anything over 2^31 would fail with an integer overflow.
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
Corresponding code change https://github.com/neo-technology/neo4j/pull/23063 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing them, @emmaholmbergohlsson!
No problem. Can I leave merging and cherry-picking to you @renetapopova or should I do something more? |
I'll do it. |
@emmaholmbergohlsson, is this change applicable to 5.15 or to the current version? The docs are currently on 5.13. |
The real limit has always been 2^31, so it is applicable to current version as well. |
2^32 labels has never actually been supported, anything over 2^31 would fail with an integer overflow.
2^32 labels has never actually been supported, anything over 2^31 would fail with an integer overflow.
2^32 labels has never actually been supported, anything over 2^31 would fail with an integer overflow. Cherry-picked from #1176 Co-authored-by: emmaholmbergohlsson <[email protected]>
2^32 labels has never actually been supported, anything over 2^31 would fail with an integer overflow. Cherry-picked from #1176 Co-authored-by: emmaholmbergohlsson <[email protected]>
2^32 labels has never actually been supported,
anything over 2^31 would fail with an integer overflow.