Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #549: Upgrade kafka-avro-serializer dependency #573

Merged
merged 8 commits into from
Sep 1, 2023

Conversation

mroiter-larus
Copy link
Contributor

Fixes #549

Updated versions of the following libraries:

  • io.confluent.kafka.avro.serializer, from 5.2.2 to 7.4.0
  • org.apache.avro.avro, from 1.8.2 to 1.11.2
  • com.google.guava.guava, from 27.0.1-jre to 32.1.1-jre
  • org.apache.kafka.kafka-clients and org.apache.kafka.connect-api, from 2.4.1 to 3.5.1

Fixed also a couple of compilation error in CommonExtension.kt and KafkaErrorServiceTest.kt

@mroiter-larus mroiter-larus added dependencies Pull requests that update a dependency file draft labels Jul 26, 2023
Copy link
Contributor

@ali-ince ali-ince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not move to the latest kafka. I also suggested to upgrade other dependencies too, but happy to see it as a separate PR if you prefer so.

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@conker84 conker84 marked this pull request as ready for review August 30, 2023 07:57
@conker84
Copy link
Contributor

conker84 commented Sep 1, 2023

@ali-ince we had to downgrade to 2.14.3 as with 2.15 was complaining about classes compiled with Java 17.

Copy link
Contributor

@ali-ince ali-ince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ali-ince
Copy link
Contributor

ali-ince commented Sep 1, 2023

also just checked the jackson jdk compatibility and it looks like it is still on java 8? 😕

@conker84
Copy link
Contributor

conker84 commented Sep 1, 2023

also just checked the jackson jdk compatibility and it looks like it is still on java 8? 😕

Yep I checked it to, that's odd...

@conker84 conker84 merged commit fead34b into neo4j-contrib:4.1 Sep 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file draft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants