Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support divorces, add marriage information #15

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Conversation

fbiville
Copy link
Collaborator

@fbiville fbiville commented Sep 25, 2024

The existing IS_MARRIED_TO has been changed to IS_SPOUSE_OF.

IS_SPOUSE_OF is inferred from family's HUSB / WIFE tags.

IS_MARRIED_TO relationships are now only created if there are
marriage family event information (MARR Gedcom tag).

DIVORCED relationships are created from family divorce event
information (DIV Gedcom tag).

@fbiville fbiville marked this pull request as ready for review September 25, 2024 20:53
@fbiville fbiville changed the title Family extractor feat: support divorces, add marriage information Sep 25, 2024
@fbiville
Copy link
Collaborator Author

fbiville commented Sep 25, 2024

Note: I'm growing skeptical about the use of present tense in the relationship types.
Do the phrasings IS_SPOUSE_OF and IS_MARRIED_TO make sense when people later divorced? Do they make sense for deceased people?
@dhrudevalia wdyt?

@dhrudevalia
Copy link
Collaborator

dhrudevalia commented Sep 27, 2024

Note: I'm growing skeptical about the use of present tense in the relationship types. Do the phrasings IS_SPOUSE_OF and IS_MARRIED_TO make sense when people later divorced? Do they make for deceased people? @dhrudevalia wdyt?

hmm yeah i've been thinking but not sure what the best approach would be.

Maybe WED_TO? HAS_BEEN_MARRIED_TO. or even to MARRIED_TO. Without the IS

@fbiville
Copy link
Collaborator Author

Let's maybe follow up in another PR when we get rid of of IS_? Wdyt?

@dhrudevalia
Copy link
Collaborator

Let's maybe follow up in another PR when we get rid of of IS_? Wdyt?

Yep that's fine with me.

The existing `IS_MARRIED_TO` has been changed to `IS_SPOUSE_OF`.

`IS_SPOUSE_OF` is inferred from family's `HUSB` / `WIFE` tags.

`IS_MARRIED_TO` relationships are now only created if there are
marriage family event information (`MARR` Gedcom tag).

`DIVORCED` relationships are created from family divorce event
information (`DIV` Gedcom tag).
@fbiville fbiville merged commit 35ac8dc into main Nov 21, 2024
26 checks passed
@fbiville fbiville deleted the family_extractor branch November 21, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants