-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support divorces, add marriage information #15
Conversation
94c7740
to
ac41346
Compare
Note: I'm growing skeptical about the use of present tense in the relationship types. |
hmm yeah i've been thinking but not sure what the best approach would be. Maybe |
Let's maybe follow up in another PR when we get rid of of |
Yep that's fine with me. |
The existing `IS_MARRIED_TO` has been changed to `IS_SPOUSE_OF`. `IS_SPOUSE_OF` is inferred from family's `HUSB` / `WIFE` tags. `IS_MARRIED_TO` relationships are now only created if there are marriage family event information (`MARR` Gedcom tag). `DIVORCED` relationships are created from family divorce event information (`DIV` Gedcom tag).
ac41346
to
9a4c911
Compare
Signed-off-by: Florent Biville <[email protected]>
Signed-off-by: Florent Biville <[email protected]>
894f8b0
to
147ff2a
Compare
The existing
IS_MARRIED_TO
has been changed toIS_SPOUSE_OF
.IS_SPOUSE_OF
is inferred from family'sHUSB
/WIFE
tags.IS_MARRIED_TO
relationships are now only created if there aremarriage family event information (
MARR
Gedcom tag).DIVORCED
relationships are created from family divorce eventinformation (
DIV
Gedcom tag).