Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 21 and 2024.12.0 bump #4230

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Java 21 and 2024.12.0 bump #4230

wants to merge 5 commits into from

Conversation

gem-neo4j
Copy link
Contributor

Update to Java 21 and Neo 2024.12.0

@vga91
Copy link
Collaborator

vga91 commented Nov 19, 2024

@gem-neo4j

I don't know how far along this PR is, but I think this commit is also needed to make the CI green: 505ecd5.

Otherwise, we'll get this error: https://github.com/neo4j-contrib/neo4j-apoc-procedures/actions/runs/11707717937/job/32716503891?pr=4222#step:10:1855.

Or at least, I had this error before the Java 21-related errors, I guess it's still present..

@gem-neo4j
Copy link
Contributor Author

Ah thanks! will take a look :)

@gem-neo4j gem-neo4j force-pushed the dev_bump_2024.12.0 branch 5 times, most recently from 9d46be0 to 1021808 Compare November 20, 2024 07:46
@vga91
Copy link
Collaborator

vga91 commented Nov 25, 2024

@gem-neo4j
To solve CI error, I guess we have to change here,
to handle "extendedCypher25.txt" and "extendedCypher5.txt" instead of / besides "extended.txt" :)

@gem-neo4j
Copy link
Contributor Author

@vga91 yep, I have another PR for that on core :) (was out sick so sorry for late reply), will try to get it all working this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants