WSS: Add Web Socket Server

[Jim8y]

Trying to add a wss plugin.

neo-project/neo#2853 This is a good suggestion, maybe we can have wss supported

[cschuchardt88]

I think you should be using ConcurrentDictionary, so you dont have to use Lock. Reason being if have, let's say a million clients using "lock" will have a delay and lock the thread for new clients connecting to the server. You can use ConcurrentDictionary to fix this problem. because like i said new clients wont get a response. especially if there is blocks with 5k transactions in it. They would be waiting for lock to be lifted.

[cschuchardt88]

is there a way for other plugins to add functionality to the wss like RPCMethhods works?

[cschuchardt88]

This for runtime only correct? or can you go back in time. Like the place you disconnected. I didn't see anything in code and was just wondering if it was thought upon for maybe a future feature add-on. Other than that it looks good. Thanks for changing to ConcurrentDictionary. Locking can be a pain, I have ran into it too many times in the pass.

[Jim8y]

@cschuchardt88 jsut made it runtime. can add other features little by little, otherwise this pr would be too complex to review.

[Jim8y]

is there a way for other plugins to add functionality to the wss like RPCMethhods works?

No, not going to make it work that way. this is just for event notification.

[cschuchardt88]

#716 mentions SendRawTransaction or InvokeScript/InvokeFunction for WSS. I didn't see anything in code. Thought you might be interested in adding.

[Jim8y]

#716 mentions SendRawTransaction or InvokeScript/InvokeFunction for WSS. I didn't see anything in code. Thought you might be interested in adding.

Well,,,,maybe i should combine rpc and wss plugins to add those rpc methods

[cschuchardt88]

Why don't you just import RpcServer plugin? Than you can just call those methods. It would work the same way as neo-express .

<PackageReference Include="Neo.Network.RPC.RpcClient" Version="3.6.1" />

[Jim8y]

casue my first thought is they should be seperate projects and do not rely on each other. Let's try to have your rest done first, rpc will be updated anyway.

[cschuchardt88]

True, I was just thinking less code to maintain.

[cschuchardt88]

@Liaojinghui
I have a solution that only uses pure asp.net core methods just like rpc server and rest web server. It works the exactly the same as RPCServer with the RpcMethod attributes. You just add WebSocketMethod attribute to the same methods. However i am use newtonsoft json serializers. I really think we need to switch core to use newtonsoft or add some kind of attribute like newtonsoft has for knowing whether to serialize the property or field.

Check it out. If you like I can convert to neo-cli module and create PR and remove newtonsoft to use neo.json https://github.com/cschuchardt88/neo-express/blob/construct/v4.0.0/src/neoxp/Node/Modules/ExpressWebSocketServerPlugin.cs

see in action

Recording.2023-11-21.204801.mp4

[Jim8y]

@cschuchardt88 its a good idea, we can discuss it later after the monorepo.

[Jim8y]

use #847 instead