HICME and HICSE segments are not Geschaeftsvorfaelle (unlike HICxES) #466
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error with scheduled SEPA transfers.
The HICSE/HICME segment response from the bank was parsed incorrectly, throwing an InvalidResponseException ('Invalid Response from serverInvalid int: ') after the Bank accepted the transfer.
This occured because the HICSEv1/HICMEv1 classes inherited additional integer properties from BaseGeschaeftsvorfallparameter, which the parser is looking for in vain while reading the one string parameter of HICME.
In contrast, the HICMESv1 and HICSESv1 segments are correctly inherited from BaseGeschaeftsvorfallparameter.